Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(book): first Logo's handbook version #319

Merged
merged 46 commits into from
Dec 21, 2023
Merged

chore(book): first Logo's handbook version #319

merged 46 commits into from
Dec 21, 2023

Conversation

jeertmans
Copy link
Collaborator

@jeertmans jeertmans commented Jun 25, 2023

Hi @maciejhirsz!

I have finally completed the book with all the information I felt important.

Even though building the book on the book branch is fine, having two separate "main" branches in active development feels quite tedious to keep up-to-date, especially as some of what is displayed in the book directly depends on the crates' content.

Therefore, I think it can reduce the amount of git rebase commands if everything is in one branch, i.e., the master one. The master branch will also benefit from the new examples I added to document the book, that will be scraped by docs.rs for... examples! And that are also tested for compilation.

I tried to check for spelling and grammar mistakes, but it may not be perfect :'-)

Also, I would gladly take any comment / remark on this.

I prefer that you review this before it is merged onto master. I understand that it is quite large PR, and reviewing may take some time ^^'.

You can directly see the book rendered here: https://logos.maciej.codes/.

maciejhirsz and others added 30 commits April 13, 2023 21:53
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

---------

Co-authored-by: Maciej Hirsz <[email protected]>
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* Auto stash before rebase of "maciejhirsz/book"

* chore(book): typos and styling

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Marcin Wojnarowski <[email protected]>
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* Auto stash before rebase of "maciejhirsz/book"

* chore(book): typos and styling

* chore(lib/book): more lib's doc to book

Hello,

This PR proposes to move all the documentation-related content to the book, so that everything is documented in one place. This will prevent future errors that occur when the same content must be update in multiple places.

The book is not finished yet though :-)

* try(ci): fixing github pages

* fix(ci): fix book path

* fix(ci): reset branch

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Marcin Wojnarowski <[email protected]>
* chore(book): document extras

Hey! This small PR adds an example for `Extras` and documents it in the book.

* chore(examples): fix typo
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

---------

Co-authored-by: Maciej Hirsz <[email protected]>
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* Auto stash before rebase of "maciejhirsz/book"

* chore(book): typos and styling

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Marcin Wojnarowski <[email protected]>
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* Auto stash before rebase of "maciejhirsz/book"

* chore(book): typos and styling

* chore(lib/book): more lib's doc to book

Hello,

This PR proposes to move all the documentation-related content to the book, so that everything is documented in one place. This will prevent future errors that occur when the same content must be update in multiple places.

The book is not finished yet though :-)

* try(ci): fixing github pages

* fix(ci): fix book path

* fix(ci): reset branch

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Marcin Wojnarowski <[email protected]>
* chore(book): document extras

Hey! This small PR adds an example for `Extras` and documents it in the book.

* chore(examples): fix typo
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

---------

Co-authored-by: Maciej Hirsz <[email protected]>
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* Auto stash before rebase of "maciejhirsz/book"

* chore(book): typos and styling

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Marcin Wojnarowski <[email protected]>
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* Auto stash before rebase of "maciejhirsz/book"

* chore(book): typos and styling

* chore(lib/book): more lib's doc to book

Hello,

This PR proposes to move all the documentation-related content to the book, so that everything is documented in one place. This will prevent future errors that occur when the same content must be update in multiple places.

The book is not finished yet though :-)

* try(ci): fixing github pages

* fix(ci): fix book path

* fix(ci): reset branch

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Marcin Wojnarowski <[email protected]>
* chore(book): document extras

Hey! This small PR adds an example for `Extras` and documents it in the book.

* chore(examples): fix typo
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

---------

Co-authored-by: Maciej Hirsz <[email protected]>
jeertmans and others added 13 commits June 25, 2023 18:53
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* Auto stash before rebase of "maciejhirsz/book"

* chore(book): typos and styling

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Marcin Wojnarowski <[email protected]>
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

* chore(docs): adding brainfuck example

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* chore(docs): adding brainfuck example

* Add missing `Debug` error type requirement (#298)

* chore(docs): create JSON example

* chore(ci): test code examples

* chore(docs): scrape examples and autodoc features

* Auto stash before rebase of "maciejhirsz/book"

* chore(book): typos and styling

* chore(lib/book): more lib's doc to book

Hello,

This PR proposes to move all the documentation-related content to the book, so that everything is documented in one place. This will prevent future errors that occur when the same content must be update in multiple places.

The book is not finished yet though :-)

* try(ci): fixing github pages

* fix(ci): fix book path

* fix(ci): reset branch

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Marcin Wojnarowski <[email protected]>
* chore(book): document extras

Hey! This small PR adds an example for `Extras` and documents it in the book.

* chore(examples): fix typo
@jeertmans jeertmans added book Related to the book documentation Related to the library docs labels Jun 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2023

Codecov Report

Merging #319 (671be13) into master (b1406db) will decrease coverage by 0.81%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   20.88%   20.08%   -0.81%     
==========================================
  Files          32       34       +2     
  Lines        2049     2131      +82     
==========================================
  Hits          428      428              
- Misses       1621     1703      +82     
Impacted Files Coverage Δ
logos/examples/brainfuck.rs 0.00% <0.00%> (ø)
logos/examples/json.rs 0.00% <0.00%> (ø)
logos/src/lexer.rs 76.05% <0.00%> (-2.21%) ⬇️
logos/src/lib.rs 33.33% <ø> (ø)

@github-actions
Copy link

github-actions bot commented Jun 25, 2023

Benchmark results:

group                                         before                                 changes
-----                                         ------                                 -------
count_ok/identifiers                          1.00  1238.5±23.72ns   599.8 MB/sec    1.03  1275.7±99.34ns   582.4 MB/sec
count_ok/keywords_operators_and_punctators    1.00      3.3±0.14µs   624.8 MB/sec    1.00      3.2±0.12µs   627.9 MB/sec
count_ok/strings                              1.07  1029.6±47.71ns   806.8 MB/sec    1.00   965.9±26.53ns   860.0 MB/sec
iterate/identifiers                           1.00  1187.9±31.35ns   625.4 MB/sec    1.04  1231.1±156.01ns   603.5 MB/sec
iterate/keywords_operators_and_punctators     1.00      3.2±0.14µs   633.6 MB/sec    1.02      3.3±0.14µs   623.4 MB/sec
iterate/strings                               1.15  1098.7±39.35ns   756.1 MB/sec    1.00   955.1±32.12ns   869.7 MB/sec

@jeertmans jeertmans requested a review from maciejhirsz June 25, 2023 17:05
@jeertmans jeertmans merged commit 99e0bcb into master Dec 21, 2023
@jeertmans jeertmans deleted the book branch December 21, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
book Related to the book documentation Related to the library docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for word boundries Sublexers using callbacks in documentation
3 participants