-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): automatically build handbook #293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeertmans
changed the title
chore(ci): automatically build
chore(ci): automatically build handbook
Apr 13, 2023
Rebasing your book branch onto master should solve this, because this PR is pretty minimalist, and aims to pave the way for the future of the handbook. |
maciejhirsz
approved these changes
Apr 13, 2023
Diff got a bit wonky, but this works, cheers! |
Nice! I will soon start to work a bit on the handbook. Do you prefer that I do PRs on your book branch or on the master one? |
I'd say let's keep it in the |
jeertmans
added a commit
to jeertmans/logos
that referenced
this pull request
Jun 23, 2023
* Initial commit for the Logos Handboook * A bit more adds to the book * chore(ci): setup automated CI for book * chore(ci): update branches * fix(ci): remove extra needs --------- Co-authored-by: Maciej Hirsz <[email protected]>
jeertmans
added a commit
that referenced
this pull request
Jun 23, 2023
* Initial commit for the Logos Handboook * A bit more adds to the book * chore(ci): setup automated CI for book * chore(ci): update branches * fix(ci): remove extra needs --------- Co-authored-by: Maciej Hirsz <[email protected]>
jeertmans
added a commit
that referenced
this pull request
Jun 25, 2023
* Initial commit for the Logos Handboook * A bit more adds to the book * chore(ci): setup automated CI for book * chore(ci): update branches * fix(ci): remove extra needs --------- Co-authored-by: Maciej Hirsz <[email protected]>
jeertmans
added a commit
that referenced
this pull request
Jun 25, 2023
* Initial commit for the Logos Handboook * A bit more adds to the book * chore(ci): setup automated CI for book * chore(ci): update branches * fix(ci): remove extra needs --------- Co-authored-by: Maciej Hirsz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this small PR to propose automating the build and deploying of Logos handbook.
This will surely help people see new versions of the handbook. Currently, this deploys from the book branch, but in the end it should use the master branch.
This PR also rebases onto the master branch.
A small setup is required from your site to allow deploying a GitHub page from a workflow from the book branch.