`logos-codegen` test failure in `s390x` #427

LecrisUT · 2024-10-08T15:21:32Z

Hi, I am updating logos to 0.14.2 on Fedora, when I've encountered the following issue when building for s390x:

running 2 tests
test test_codegen::case_1 ... ok
test test_codegen::case_2 ... FAILED

I have diffed the results of each one, and they look drastically different:

left

impl<'s> ::logos::Logos<'s> for Token {
    type Error = ();
    type Extras = ();
    type Source = [u8];
    fn lex(lex: &mut ::logos::Lexer<'s, Self>) {
        use ::logos::internal::{LexerInternal, CallbackResult};
        type Lexer<'s> = ::logos::Lexer<'s, Token>;
        fn _end<'s>(lex: &mut Lexer<'s>) { lex.end() }
        fn _error<'s>(lex: &mut Lexer<'s>) {
            lex.bump_unchecked(1);
            lex.error();
        } macro_rules! _fast_loop { ($ lex : ident , $ test : ident , $ miss : expr) => { while let Some (arr) = $ lex . read :: < & [u8 ; 16] > () { if $ test (arr [0]) { if $ test (arr [1]) { if $ test (arr [2]) { if $ test (arr [3]) { if $ test (arr [4]) { if $ test (arr [5]) { if $ test (arr [6]) { if $ test (arr [7]) { if $ test (arr [8]) { if $ test (arr [9]) { if $ test (arr [10]) { if $ test (arr [11]) { if $ test (arr [12]) { if $ test (arr [13]) { if $ test (arr [14]) { if $ test (arr [15]) { $ lex . bump_unchecked (16) ; continue ; } $ lex . bump_unchecked (15) ; return $ miss ; } $ lex . bump_unchecked (14) ; return $ miss ; } $ lex . bump_unchecked (13) ; return $ miss ; } $ lex . bump_unchecked (12) ; return $ miss ; } $ lex . bump_unchecked (11) ; return $ miss ; } $ lex . bump_unchecked (10) ; return $ miss ; } $ lex . bump_unchecked (9) ; return $ miss ; } $ lex . bump_unchecked (8) ; return $ miss ; } $ lex . bump_unchecked (7) ; return $ miss ; } $ lex . bump_unchecked (6) ; return $ miss ; } $ lex . bump_unchecked (5) ; return $ miss ; } $ lex . bump_unchecked (4) ; return $ miss ; } $ lex . bump_unchecked (3) ; return $ miss ; } $ lex . bump_unchecked (2) ; return $ miss ; } $ lex . bump_unchecked (1) ; return $ miss ; } return $ miss ; } while $ lex . test ($ test) { $ lex . bump_unchecked (1) ; } $ miss } ; } #[inline]
        fn goto11_ctx11_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::Any)); }
        #[inline]
        fn goto2_ctx11_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::AnyUnicode)); }
        #[inline]
        fn goto18_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 3usize]>() {
                Some([128u8..=191u8, 128u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(3usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto1_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::Newline)); }
        #[inline]
        fn goto17_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 3usize]>() {
                Some([144u8..=191u8, 128u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(3usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto11_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::Any)); }
        #[inline]
        fn goto16_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 2usize]>() {
                Some([128u8..=159u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(2usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto15_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 2usize]>() {
                Some([128u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(2usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto14_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 2usize]>() {
                Some([160u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(2usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto19_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 3usize]>() {
                Some([128u8..=143u8, 128u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(3usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto13_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 1usize]>() {
                Some([128u8..=191u8]) => {
                    lex.bump_unchecked(1usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto2_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::AnyUnicode)); }
        #[inline]
        fn goto20<'s>(lex: &mut Lexer<'s>) {
            enum Jump { J18, J1, J17, J11, J16, J15, J14, J19, J13, J2 }
            const LUT: [Jump; 256] = {
                use Jump::*;
                [J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J1, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J14, J15, J15, J15, J15, J15, J15, J15, J15, J15, J15, J15, J15, J16, J15, J15, J17, J18, J18, J18, J19, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11]
            };
            let byte = match lex.read::<u8>() {
                Some(byte) => byte,
                None => return _end(lex),
            };
            match LUT[byte as usize] {
                Jump::J18 => {
                    lex.bump_unchecked(1usize);
                    goto18_ctx11_x(lex)
                }
                Jump::J1 => {
                    lex.bump_unchecked(1usize);
                    goto1_x(lex)
                }
                Jump::J17 => {
                    lex.bump_unchecked(1usize);
                    goto17_ctx11_x(lex)
                }
                Jump::J11 => {
                    lex.bump_unchecked(1usize);
                    goto11_x(lex)
                }
                Jump::J16 => {
                    lex.bump_unchecked(1usize);
                    goto16_ctx11_x(lex)
                }
                Jump::J15 => {
                    lex.bump_unchecked(1usize);
                    goto15_ctx11_x(lex)
                }
                Jump::J14 => {
                    lex.bump_unchecked(1usize);
                    goto14_ctx11_x(lex)
                }
                Jump::J19 => {
                    lex.bump_unchecked(1usize);
                    goto19_ctx11_x(lex)
                }
                Jump::J13 => {
                    lex.bump_unchecked(1usize);
                    goto13_ctx11_x(lex)
                }
                Jump::J2 => { lex.bump_unchecked(1usize) ; goto2_x (lex) }
} } goto20 (lex) } }

right

impl<'s> ::logos::Logos<'s> for Token {
    type Error = ();
    type Extras = ();
    type Source = [u8];
    fn lex(lex: &mut ::logos::Lexer<'s, Self>) {
        use ::logos::internal::{LexerInternal, CallbackResult};
        type Lexer<'s> = ::logos::Lexer<'s, Token>;
        fn _end<'s>(lex: &mut Lexer<'s>) { lex.end() }
        fn _error<'s>(lex: &mut Lexer<'s>) {
            lex.bump_unchecked(1);
            lex.error();
        } macro_rules! _fast_loop { ($ lex : ident , $ test : ident , $ miss : expr) => { while let Some (arr) = $ lex . read :: < & [u8 ; 16] > () { if $ test (arr [0]) { if $ test (arr [1]) { if $ test (arr [2]) { if $ test (arr [3]) { if $ test (arr [4]) { if $ test (arr [5]) { if $ test (arr [6]) { if $ test (arr [7]) { if $ test (arr [8]) { if $ test (arr [9]) { if $ test (arr [10]) { if $ test (arr [11]) { if $ test (arr [12]) { if $ test (arr [13]) { if $ test (arr [14]) { if $ test (arr [15]) { $ lex . bump_unchecked (16) ; continue ; } $ lex . bump_unchecked (15) ; return $ miss ; } $ lex . bump_unchecked (14) ; return $ miss ; } $ lex . bump_unchecked (13) ; return $ miss ; } $ lex . bump_unchecked (12) ; return $ miss ; } $ lex . bump_unchecked (11) ; return $ miss ; } $ lex . bump_unchecked (10) ; return $ miss ; } $ lex . bump_unchecked (9) ; return $ miss ; } $ lex . bump_unchecked (8) ; return $ miss ; } $ lex . bump_unchecked (7) ; return $ miss ; } $ lex . bump_unchecked (6) ; return $ miss ; } $ lex . bump_unchecked (5) ; return $ miss ; } $ lex . bump_unchecked (4) ; return $ miss ; } $ lex . bump_unchecked (3) ; return $ miss ; } $ lex . bump_unchecked (2) ; return $ miss ; } $ lex . bump_unchecked (1) ; return $ miss ; } return $ miss ; } while $ lex . test ($ test) { $ lex . bump_unchecked (1) ; } $ miss } ; } #[inline]
        fn goto1_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::Newline)); }
        #[inline]
        fn goto11_ctx11_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::Any)); }
        #[inline]
        fn goto2_ctx11_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::AnyUnicode)); }
        #[inline]
        fn goto16_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 2usize]>() {
                Some([128u8..=159u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(2usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto17_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 3usize]>() {
                Some([144u8..=191u8, 128u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(3usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto2_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::AnyUnicode)); }
        #[inline]
        fn goto13_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 1usize]>() {
                Some([128u8..=191u8]) => {
                    lex.bump_unchecked(1usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto18_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 3usize]>() {
                Some([128u8..=191u8, 128u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(3usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto15_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 2usize]>() {
                Some([128u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(2usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto14_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 2usize]>() {
                Some([160u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(2usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto19_ctx11_x<'s>(lex: &mut Lexer<'s>) {
            match lex.read::<&[u8; 3usize]>() {
                Some([128u8..=143u8, 128u8..=191u8, 128u8..=191u8]) => {
                    lex.bump_unchecked(3usize);
                    goto2_ctx11_x(lex)
                }
                _ => goto11_ctx11_x(lex),
            }
        }
        #[inline]
        fn goto11_x<'s>(lex: &mut Lexer<'s>) { lex.set(Ok(Token::Any)); }
        #[inline]
        fn goto20<'s>(lex: &mut Lexer<'s>) {
            enum Jump { J1, J16, J17, J2, J13, J18, J15, J14, J19, J11 }
            const LUT: [Jump; 256] = {
                use Jump::*;
                [J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J1, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J2, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J13, J14, J15, J15, J15, J15, J15, J15, J15, J15, J15, J15, J15, J15, J16, J15, J15, J17, J18, J18, J18, J19, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11, J11]
            };
            let byte = match lex.read::<u8>() {
                Some(byte) => byte,
                None => return _end(lex),
            };
            match LUT[byte as usize] {
                Jump::J1 => {
                    lex.bump_unchecked(1usize);
                    goto1_x(lex)
                }
                Jump::J16 => {
                    lex.bump_unchecked(1usize);
                    goto16_ctx11_x(lex)
                }
                Jump::J17 => {
                    lex.bump_unchecked(1usize);
                    goto17_ctx11_x(lex)
                }
                Jump::J2 => {
                    lex.bump_unchecked(1usize);
                    goto2_x(lex)
                }
                Jump::J13 => {
                    lex.bump_unchecked(1usize);
                    goto13_ctx11_x(lex)
                }
                Jump::J18 => {
                    lex.bump_unchecked(1usize);
                    goto18_ctx11_x(lex)
                }
                Jump::J15 => {
                    lex.bump_unchecked(1usize);
                    goto15_ctx11_x(lex)
                }
                Jump::J14 => {
                    lex.bump_unchecked(1usize);
                    goto14_ctx11_x(lex)
                }
                Jump::J19 => {
                    lex.bump_unchecked(1usize);
                    goto19_ctx11_x(lex)
                }
                Jump::J11 => { lex.bump_unchecked(1usize) ; goto11_x (lex) }
} } goto20 (lex) } }

I am not sure what to make of it, could someone advise on this? Other architectures worked fine, and the main difference with s390x is that it is big-endian

build.log

The text was updated successfully, but these errors were encountered:

jeertmans · 2024-10-08T16:16:10Z

Looks like an interesting, but probably challenging bug!

do you have any other big-endian architecture you could test on to ensure the issue is endianess?

LecrisUT · 2024-10-08T16:42:26Z

Unfortunately not in Fedora builders, those are only x86_64, aarch64, i686, s390x, ppc64le. Except for ppc64le which got canceled before running, all the other architectures ran successfully and all of them are little endian. I could help set up a builder for s390x and test with and without vendored dependencies to at least test that that is not a source of issue. The easiest and least invasive way that I can provide is to create a separate repo with all the CI configuration to run on s390x and then if you can work with patch files, than you could have full access to the builder.

jeertmans · 2024-10-08T18:40:28Z

I you can find a github runner or docker image that runs big endian and create a PR that adds a workflow on that architecture, that would greatly help reproducing your error :)

LecrisUT · 2024-10-08T18:46:44Z

Maybe can try out with https://github.com/uraimo/run-on-arch-action?

jeertmans · 2024-10-08T20:50:41Z

Yes this looks like a good direction! Would you have time to work on a PR?

LecrisUT · 2024-10-09T11:04:38Z

Using the GH Action wasn't really successful: #428. But I did manage to provide another reproducible environment using podman (might work with docker also) when running locally, so maybe that would also help?

jeertmans · 2024-10-09T11:48:35Z

I guess any runner / docker image with big-endian arch should be fine :-)
I am not familiar with podman, so you probably know more than me!

LecrisUT · 2024-10-09T12:23:25Z

podman is the equivalent of docker and often times the syntax is equivalent. Try out the following Containerfile:

FROM s390x/fedora:latest

RUN dnf install -y git cargo

RUN git clone https://github.com/maciejhirsz/logos /logos

WORKDIR /logos

CMD ["cargo", "test", "--workspace", "--verbose"]

with

$ docker build --platform linux/s390x -f ./Containerfile -t debug:logos-s390x
$ docker run --platform linux/s390x debug:logos-s390x

or

$ podman build --arch s390x -f ./Containerfile -t debug:logos-s390x
$ podman run --arch s390x debug:logos-s390x

I had issues with the docker one failing on building autocfg which we know shouldn't happen since Fedora builders work fine for that and I confirmed with podman that it doesn't fail there. I hope this issue is purely with the GH action and you would instead be able to work with a local docker container.

~~Another option we could try is the one from docker itself, which might work if we debug within the Containerfile itself. Would that work for you?~~ (Nope, that did not work either, with the same issues)
https://docs.docker.com/build/ci/github-actions/multi-platform/

jeertmans · 2024-10-12T13:51:41Z

Thanks for your investigation!

A small question I should have asked from the start:

Hi, I am updating logos to 0.14.2 on Fedora, when I've encountered the following issue when building for s390x:

Is this problem present with earlier versions of Logos?

I also see that you link

https://docs.docker.com/build/ci/github-actions/multi-platform/

Did you already give it a try?

LecrisUT · 2024-10-12T14:13:37Z

It actually passed in 0.13.0. I haven't tested the other ones though.

Did you already give it a try?

Yep, consistently the same error. I'll setup a copr builder in a bit

jeertmans · 2024-10-13T10:08:17Z

Could you check with 0.14.0, and 0.14.1? To better identify which version introduced the bug.

LecrisUT · 2024-10-13T12:05:59Z

I can only check as low as 0.14.1 because before that the tests were not present. Iirc the error happened there as well, but I'll double check tomorrow (checked and confirmed it was still an issue with 0.14.1).

0x2a-42 · 2024-10-14T19:41:51Z

As far as I can tell, the only difference between result and reference is the order of functions, enumerators, and match branches. The output depends on the iteration order of a HashMap.

logos/logos-codegen/src/generator/fork.rs

Lines 73 to 88 in 30ffb42

    
           let branches = targets 
        
               .into_iter() 
        
               .enumerate() 
        
               .map(|(idx, (id, ranges))| { 
        
                   let idx = (idx as u8) + 1; 
        
                   let next = self.goto(id, ctx.advance(1)); 
        
                   jumps.push(format!("J{}", id).to_ident()); 
        
                   for byte in ranges.into_iter().flatten() { 
        
                       table[byte as usize] = idx; 
        
                   } 
        
                   let jump = jumps.last().unwrap(); 
        
                   quote!(Jump::#jump => #next,) 
        
               }) 
        
               .collect::<TokenStream>();

logos/logos-codegen/src/generator/fork.rs

Line 11 in 30ffb42

type Targets = Map<NodeId, Vec<Range>>;

logos/logos-codegen/src/generator/fork.rs

Line 3 in 30ffb42

use fnv::FnvHashMap as Map;

The key type uses the default Hash implementation of NonZeroU32

logos/logos-codegen/src/graph/mod.rs

Lines 61 to 62 in 30ffb42

    
           #[derive(Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)] 
        
           pub struct NodeId(NonZeroU32);

which in turn uses the same Hash implementation as u32.
https://github.com/rust-lang/rust/blob/17a19e684cdf3ca088af8b4da6a6209d128913f4/library/core/src/num/nonzero.rs#L260

The Hash implementation of u32 calls write_u32 on the provided Hasher
https://github.com/rust-lang/rust/blob/17a19e684cdf3ca088af8b4da6a6209d128913f4/library/core/src/hash/mod.rs#L835
and the Hasher implementation of FnvHasher
https://github.com/servo/rust-fnv/blob/4e55052a343a4372c191141f29a17ab829cf1dbc/lib.rs#L115
uses the default implementation of the Hasher trait for this method
https://github.com/rust-lang/rust/blob/17a19e684cdf3ca088af8b4da6a6209d128913f4/library/core/src/hash/mod.rs#L375-L377
which turns the u32 into bytes by calling to_ne_bytes.

I guess the problem could be solved by providing a custom implementation of Hash for NodeId, which always uses to_le_bytes. Using a BTreeMap would also solve the problem, as it provides guarantees for its iteration order.

If the performance impact of these solutions is not acceptable, it would be possible to adjust the test, such that there are different references for big-endian and little-endian platforms.

jeertmans added the bug Something isn't working label Oct 13, 2024

0x2a-42 mentioned this issue Oct 15, 2024

fix(lib): generate same code on big-endian platforms #431

Merged

jeertmans linked a pull request Oct 16, 2024 that will close this issue

fix(lib): generate same code on big-endian platforms #431

Merged

jeertmans closed this as completed in #431 Oct 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`logos-codegen` test failure in `s390x` #427

`logos-codegen` test failure in `s390x` #427

LecrisUT commented Oct 8, 2024

jeertmans commented Oct 8, 2024

LecrisUT commented Oct 8, 2024

jeertmans commented Oct 8, 2024

LecrisUT commented Oct 8, 2024

jeertmans commented Oct 8, 2024

LecrisUT commented Oct 9, 2024

jeertmans commented Oct 9, 2024

LecrisUT commented Oct 9, 2024 •

edited

Loading

jeertmans commented Oct 12, 2024

LecrisUT commented Oct 12, 2024

jeertmans commented Oct 13, 2024

LecrisUT commented Oct 13, 2024 •

edited

Loading

0x2a-42 commented Oct 14, 2024

logos-codegen test failure in s390x #427

logos-codegen test failure in s390x #427

Comments

LecrisUT commented Oct 8, 2024

jeertmans commented Oct 8, 2024

LecrisUT commented Oct 8, 2024

jeertmans commented Oct 8, 2024

LecrisUT commented Oct 8, 2024

jeertmans commented Oct 8, 2024

LecrisUT commented Oct 9, 2024

jeertmans commented Oct 9, 2024

LecrisUT commented Oct 9, 2024 • edited Loading

jeertmans commented Oct 12, 2024

LecrisUT commented Oct 12, 2024

jeertmans commented Oct 13, 2024

LecrisUT commented Oct 13, 2024 • edited Loading

0x2a-42 commented Oct 14, 2024

`logos-codegen` test failure in `s390x` #427

`logos-codegen` test failure in `s390x` #427

LecrisUT commented Oct 9, 2024 •

edited

Loading

LecrisUT commented Oct 13, 2024 •

edited

Loading