Typescript question for creating custom task modifiers

[LanceStasinski]

Hello, I've added a custom task modifier to restore the functionality of waitFor from @ember/test-waiters. Do you have any suggestions for improving the types for this custom modifier? Thank you in advance!

import { TaskFactory, registerModifier } from 'ember-concurrency'
import { waitFor } from '@ember/test-waiters'

declare module 'ember-concurrency' {
  interface TaskFactory<T, Args> {
    taskDefinition: Function & TaskDefinition<T, Args>
  }
}

function waitForTask<T, Args extends unknown[]>(taskFactory: TaskFactory<T, Args>, option: boolean) {
  if (!option) {
    return
  }

  const { taskDefinition } = taskFactory
  const waitForTaskDefinition = waitFor(function* (this: unknown, ...args: Args) {
    yield* taskDefinition.apply(this, args)
  })

  taskFactory.setTaskDefinition(waitForTaskDefinition)
}

export function initialize() {
  registerModifier('waitFor', waitForTask)
}

export default {
  initialize,
}

[SergeAstapov]

that will be great to bring this functionality back.
I wonder if it's worth to built into ember-concurrency itself

[NullVoxPopuli]

I wonder if it's worth to built into ember-concurrency itself

it should, yeah. @ember/test-waiters will not be integrating with ecosystem libraries (this expands scope too greatly)