Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version not reported correctly in Windows #466

Closed
machawk1 opened this issue Jun 30, 2020 · 2 comments · Fixed by #470
Closed

Version not reported correctly in Windows #466

machawk1 opened this issue Jun 30, 2020 · 2 comments · Fixed by #470

Comments

@machawk1
Copy link
Owner

Building from latest master e26e87c, the version number in About WAIL menu item reports -1, meaning it is never set.

Screen Shot 2020-06-30 at 3 24 11 PM

@machawk1
Copy link
Owner Author

This value is read from an XML file in WAILConfig.py

try:
    with open(infoPlistPath, "r", encoding='latin1') as myfile:
        data = myfile.read()
        vsXML = r"<key>CFBundleShortVersionString</key>\n\t<string>(.*)</string>"
        m = re.search(vsXML, data)
        WAIL_VERSION = m.groups()[0].strip()

...which is macOS-specific. This code was never adapted to Windows. Is this value available programmatically elsewhere?

@machawk1
Copy link
Owner Author

Screen Shot 2020-07-30 at 4 06 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant