Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review synchronize.js #4

Open
ricardojmendez opened this issue Feb 26, 2017 · 1 comment
Open

Review synchronize.js #4

ricardojmendez opened this issue Feb 26, 2017 · 1 comment
Assignees

Comments

@ricardojmendez
Copy link
Member

Review synchronize.js, consider migrating to it from fibers.

Suggested by @yogthos.

@ricardojmendez ricardojmendez self-assigned this Feb 26, 2017
@ricardojmendez
Copy link
Member Author

I've ben reviewing this and discussing it with @yogthos. In short:

  • We're not really migrating from fibers, as synchronize.js is built on them;
  • I don't really see yet what the synchronize approach buys us over futures, as far as actual use goes

We'll still need to make a synchronous wrapper for the async function, which will likely have the same drawbacks when wrapping instance methods. We'll still need to have some function grouping together the calls we want to make synchronous (whether it is a task or just a fiber). We just add a slightly different approach which could be lighter than futures, but also introduces more code (since futures are already bundled with the base fibers package).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant