Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze-Css module incorrect processing of query parameters #587

Closed
hmmdeif opened this issue Jan 14, 2016 · 1 comment
Closed

Analyze-Css module incorrect processing of query parameters #587

hmmdeif opened this issue Jan 14, 2016 · 1 comment

Comments

@hmmdeif
Copy link

hmmdeif commented Jan 14, 2016

System: Windows

Example of a css file that will fail to be analyzed due to incorrect parsing: http://www.example.com/css.css?p=1&p=2.

Since & is a special character in cmd.exe, it will disregard &p=2 and throw an error saying that it is an invalid command.

I solved this for myself by modifying modules\analyzeCss.js:135 to analyzeCss(['--url', entry.url.replace(/&/g, "^^^&")]); which escapes the ampersands.

@macbre macbre added the bug label Jan 14, 2016
@macbre macbre added this to the v1.14 milestone Jan 14, 2016
@macbre macbre modified the milestones: v1.14, v1.15 Jan 30, 2016
@macbre
Copy link
Owner

macbre commented Mar 13, 2016

Fixed.

@hmmdeif, can you check if it works for you? I do not have access to any Windows machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants