Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple runs in CommonJS module #362

Closed
stefanjudis opened this issue Jun 28, 2014 · 2 comments
Closed

Multiple runs in CommonJS module #362

stefanjudis opened this issue Jun 28, 2014 · 2 comments

Comments

@stefanjudis
Copy link
Contributor

Hey @macbre,

just wanted to switch to your stats generation and functionality of multiple runs, but as far as I see it's only implemented for phantomas/bin/phantomas.js, when kicking off via CLI?

Maybe I'm wrong, but my usecase would be to use it via the npm module. 😊

@macbre
Copy link
Owner

macbre commented Jun 28, 2014

You're right, the multiple run is currently handled by the "binary" script, not the CommonJS module. Implementing it in CommonJS would require some changes in its API. I'd like to keep the main phantomas module entry point to make a single run.

Stats generation functionality is implemented by reporters which are also run from within "binary" - there's a ticket for moving them to CommonJS module - #279

@macbre macbre added this to the Roadmap milestone Jun 28, 2014
@macbre macbre changed the title Runs in CommonJS module Multiple runs in CommonJS module Jun 28, 2014
@stefanjudis
Copy link
Contributor Author

Okay thanks. :)

I'd like to keep the main phantomas module entry point to make a single run.

Jap, agree. This is cleaner.

I'll close this one then. :bowtie:

@macbre macbre modified the milestone: Roadmap Oct 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants