feat: Add sideloaded kit example #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
force-pushed
the
feat/SQDSDKS-5116-add-side-loaded-kit
branch
2 times, most recently
from
70c4824 to
ceac3ae
Compare
alexs-mparticle
requested changes
Mar 10, 2023
core-sdk-samples/mp-sideloaded-kit-example/src/initialization.js
Outdated
Show resolved
Hide resolved
core-sdk-samples/mp-sideloaded-kit-example/src/session-handler.js
Outdated
Show resolved
Hide resolved
core-sdk-samples/mp-sideloaded-kit-example/src/user-attribute-handler.js
Outdated
Show resolved
Hide resolved
core-sdk-samples/higgs-shop-sample-app/src/layouts/App/index.tsx
Outdated
Show resolved
Hide resolved
core-sdk-samples/higgs-shop-sample-app/src/layouts/App/index.tsx
Outdated
Show resolved
Hide resolved
core-sdk-samples/mp-sideloaded-kit-example/src/user-attribute-handler.js
Outdated
Show resolved
Hide resolved
core-sdk-samples/mp-sideloaded-kit-example/src/user-attribute-handler.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex S <[email protected]>
rmi22186
force-pushed
the
feat/SQDSDKS-5116-add-side-loaded-kit
branch
from
9fe58e3 to
85d750d
Compare
core-sdk-samples/higgs-shop-sample-app/src/layouts/App/mpconfig.prod.json
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,683 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Should we have a build task that produces these, rather than have them get committed?
|
Seems like the sideloaded kit wasn't checked in, just the app changes? |
@einsteinx2 - this was included initially but alex had some feedback about moving it, and it was dropped in one of the commits. it has now been added back after testing. |
einsteinx2
previously approved these changes
Mar 14, 2023
|
This is blocked by a release for the web sdk to support the feature. Once that has been released, we can merge this upon approval. We should update the package.json for the @mparticle/web-sdk to be 2.20.x |
package-lock.json
Outdated
There was a problem hiding this comment.
Please delete this file
alexs-mparticle
approved these changes
Mar 16, 2023
rmi22186
added a commit
that referenced
this pull request
Mar 20, 2023
rmi22186
added a commit
that referenced
this pull request
Mar 20, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
# [1.5.0](v1.4.2...v1.5.0) (2023-03-21) ### Features * Add sideloaded kit example ([#494](#494)) ([bba9c2c](bba9c2c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
Summary
This PR includes a custom sideloaded kit that will fire on every mapped mParticle method. The sideloaded kit was placed as a sibling of
higgs-shop-sample-app.Testing Plan
Master Issue