You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
As noted in #94 wrapping errors with fmt.Errorf, i.e.
if err != nil {
return fmt.Errorf("context about error: %v" err)
}
loses the type information of the error which is being wrapped. Consequently, we should audit the m3db codebases to replace all calls to fmt.Errorf with calls to errors.Wrap and errors.Wrapf. For the longer term, it may be worthwhile to add a custom linter for issues specific to repos under the m3db organization to the gometalinter suite and include this issue as one of the lints.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As noted in #94 wrapping errors with
fmt.Errorf
, i.e.loses the type information of the error which is being wrapped. Consequently, we should audit the
m3db
codebases to replace all calls tofmt.Errorf
with calls toerrors.Wrap
anderrors.Wrapf
. For the longer term, it may be worthwhile to add a custom linter for issues specific to repos under them3db
organization to thegometalinter
suite and include this issue as one of the lints.The text was updated successfully, but these errors were encountered: