Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure data in etcd is cleared on cluster deletion #44

Closed
schallert opened this issue Oct 12, 2018 · 3 comments · Fixed by #154
Closed

Ensure data in etcd is cleared on cluster deletion #44

schallert opened this issue Oct 12, 2018 · 3 comments · Fixed by #154

Comments

@schallert
Copy link
Collaborator

Potentially using a finalizer or similar method to hook into cluster deletion
@prateek
Copy link
Collaborator

prateek commented Oct 12, 2018

Try not to use the go SetFinalizer call as far as you can. It has really weird guarantees that are best avoided.

@schallert
Copy link
Collaborator Author

Ah, I meant finalizer in the context of a Kubernetes finalizer

@prateek
Copy link
Collaborator

prateek commented Oct 12, 2018

👍 dope, just wanted to make sure

@schallert schallert mentioned this issue Jun 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[controller] clear data in etcd on cluster delete m3db/m3db-operator
2 participants
@prateek @schallert