Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose error messages from coordinator in m3admin client #23

Closed
schallert opened this issue Oct 4, 2018 · 1 comment
Closed

Expose error messages from coordinator in m3admin client #23

schallert opened this issue Oct 4, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@schallert
Copy link
Collaborator

The coordinator sometimes returns error messages in a JSON payload from its admin endpoints. We currently can't catch this because the default retryhttp handler masks all errors. The only way of catching these errors currently is by having debug logging on in the operator thus dumping all raw responses, which is not desirable.

We should modify the m3admin http client to attempt to parse out application-level errors from non-200 responses from the coordinator. We'll likely need to use retryhttp's Passthrough error handler and then parse out the response.

@schallert schallert added the enhancement New feature or request label Oct 4, 2018
@schallert
Copy link
Collaborator Author

We happened to address this in #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant