Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carbon ingester listener to cluster spec #157

Closed
hprotzek opened this issue Jun 27, 2019 · 3 comments
Closed

Add carbon ingester listener to cluster spec #157

hprotzek opened this issue Jun 27, 2019 · 3 comments

Comments

@hprotzek
Copy link
Contributor

Enabling the carbon listener in a custom config map doesn't open the port in the service and container. Adding EnableCarbonIngester to the cluster spec, which then generate a config map with

carbon:
    ingester:
      listenAddress: "0.0.0.0:7204"

and opening the ports in the coordinator service and the m3dbnode containers, would be very helpfull.

@hprotzek
Copy link
Contributor Author

I am working on a PR for this. I just added a boolean flag to the cluster spec EnableCarbonIngester This will work only for custom config maps, as the listener doesn't start with an empty carbon: config. Does it make sense to generate the carbon rules based on the configured namespaces in the spec?

@hprotzek
Copy link
Contributor Author

I am working on a PR for this. I just added a boolean flag to the cluster spec EnableCarbonIngester This will work only for custom config maps, as the listener doesn't start with an empty carbon: config. Does it make sense to generate the carbon rules based on the configured namespaces in the spec?

Just saw in the carbon listener code in the m3db, that if no rules supplied, default rules based on the namespaces will be generated. So no need in the operator to do so :-)

@hprotzek
Copy link
Contributor Author

hprotzek commented Jul 8, 2019

closed with #158

@hprotzek hprotzek closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant