Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add session connect consistency level #29

Merged
merged 2 commits into from
Jul 27, 2016
Merged

Add session connect consistency level #29

merged 2 commits into from
Jul 27, 2016

Conversation

robskillington
Copy link
Collaborator

@robskillington robskillington commented Jul 24, 2016 •
edited
Loading

@coveralls
Copy link

coveralls commented Jul 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 77.481% when pulling c07cebc on add-connect-consistency-level into dc94a8d on master.

xichen2020
xichen2020 reviewed Jul 26, 2016
View reviewed changes
client/session.go
break
switch connectConsistencyLevel {
case m3db.ConsistencyLevelAll:
clusterAvailable = shardReplicasAvailable == replicas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems clusterAvailable gets overridden in each iteration? should we break when clusterAvailable is false and only continue otherwise?

@coveralls
Copy link

coveralls commented Jul 27, 2016 •
edited
Loading

Coverage Status

Coverage increased (+2.9%) to 80.363% when pulling e593c76 on add-connect-consistency-level into dc94a8d on master.

@xichen2020
Copy link

LGTM

@robskillington robskillington merged commit 7d663c8 into master Jul 27, 2016
@robskillington robskillington deleted the add-connect-consistency-level branch July 27, 2016 14:16
prateek pushed a commit that referenced this pull request Jun 21, 2018
@jeromefroe @prateek
[terms dictionary] Remove trigram index code (#29)
c558d42
prateek pushed a commit that referenced this pull request Jun 21, 2018
@jeromefroe @prateek
[terms dictionary] Remove trigram index code (#29)
bebb3f3
robskillington pushed a commit that referenced this pull request Oct 7, 2018
@jeromefroe
[queue] Don't include instance in queue size metrics (#29)
2bf3c97
robskillington pushed a commit that referenced this pull request Oct 7, 2018
@jeromefroe @robskillington
[queue] Don't include instance in queue size metrics (#29)
f7f8926
prateek pushed a commit that referenced this pull request Oct 9, 2018
@cw9 @prateek
Fix config, make sure timer flush fast path is working (#29)
41bb3b3
prateek pushed a commit that referenced this pull request Oct 9, 2018
@cw9 @prateek
Fix config, make sure timer flush fast path is working (#29)
e0faa1d
cw9 added a commit that referenced this pull request Oct 12, 2018
@cw9
Reuse the buffer in encoder and decoder (#29)
768ac30
cw9 added a commit that referenced this pull request Oct 13, 2018
@cw9
Reuse the buffer in encoder and decoder (#29)
a49bae3
cw9 added a commit that referenced this pull request Oct 14, 2018
@cw9
Reuse the buffer in encoder and decoder (#29)
2034eb3
cw9 added a commit that referenced this pull request Oct 14, 2018
@cw9
Consider weights in placement algorithm (#29)
9240080
cw9 pushed a commit that referenced this pull request Oct 14, 2018
@xichen2020
Store namespace snapshots (#29)
a9d152d
cw9 pushed a commit that referenced this pull request Oct 16, 2018
@xichen2020
Store namespace snapshots (#29)
9f938d7
cw9 pushed a commit that referenced this pull request Oct 16, 2018
@xichen2020 @cw9
Store namespace snapshots (#29)
5359a6a
cw9 added a commit that referenced this pull request Oct 16, 2018
@cw9
Consider weights in placement algorithm (#29)
affbdb0
cw9 added a commit that referenced this pull request Oct 16, 2018
@cw9
Consider weights in placement algorithm (#29)
ec1de36
cw9 added a commit that referenced this pull request Oct 16, 2018
@cw9
Consider weights in placement algorithm (#29)
4d831dc
robskillington pushed a commit that referenced this pull request Feb 11, 2019
@saminzadeh
[UI] Style and Help text changes (#29)
4e9e5c0 
* Move new namespace input
* Help text
robskillington pushed a commit that referenced this pull request Feb 25, 2019
@saminzadeh
[UI] Style and Help text changes (#29)
160bd06 
* Move new namespace input
* Help text
robskillington pushed a commit that referenced this pull request Feb 25, 2019
@saminzadeh @robskillington
[UI] Style and Help text changes (#29)
f329cd3 
* Move new namespace input
* Help text
prateek pushed a commit that referenced this pull request Apr 7, 2019
@xichen2020 @prateek
Add time unit minute (#29)
31a9bf4
prateek pushed a commit that referenced this pull request Apr 8, 2019
@xichen2020 @prateek
Add time unit minute (#29)
ca9fd02
@andrewmains12 andrewmains12 mentioned this pull request Aug 17, 2020
Closed
jnyi added a commit to jnyi/m3 that referenced this pull request Jan 17, 2023
@jnyi
Merge pull request m3db#29 from jnyi/emit-preagg-rule-counts
e957bc8 
emit number of configured pre aggregtion rules as metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robskillington @coveralls @xichen2020