New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SourceAvailableHost topology test util to be easier to read #909

Closed

richardartoul opened this issue Sep 17, 2018 · 1 comment

Assignees

Labels

P: Low T: Beginner T: Refactor

Contributor

richardartoul commented Sep 17, 2018

type SourceAvailableHost struct {
	Name        string
	Shards      []uint32
	ShardStates shard.State
}

Could become something like:

func TestFetchTaggedResultsAccumulatorAnyResponseShouldTerminateConsistencyLevelOneSimpleTopo(t *testing.T) {
	// rf=3, 30 shards total; three identical hosts
	topoMap := tu.MustNewTopologyMap(3, map[string][]shard.Shard{
		"testhost0": tu.ShardsRange(0, 29, shard.Available),
		"testhost1": tu.ShardsRange(0, 29, shard.Available),
		"testhost2": tu.ShardsRange(0, 29, shard.Available),
	})

richardartoul self-assigned this

richardartoul added P: Low T: Refactor T: Beginner T: Test Improvement labels

richardartoul mentioned this issue

Add support for putting commit log bootstrapper before peers #894

Merged

8 tasks

Contributor Author

richardartoul commented Sep 17, 2018

Adressed by #894

richardartoul closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment