Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make encoder.Stream() return a bool indicating whether data is present #805

Closed
richardartoul opened this issue Jul 24, 2018 · 0 comments · Fixed by #1625
Closed

Make encoder.Stream() return a bool indicating whether data is present #805

richardartoul opened this issue Jul 24, 2018 · 0 comments · Fixed by #1625
Assignees
@prateek @robskillington @richardartoul
Labels
P: Low T: Beginner T: Misc T: Refactor

Comments

@richardartoul
Copy link
Contributor

The current interface requires a nil check against the stream result which is error prone (people forget to do it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prateek prateek

@robskillington robskillington

@richardartoul richardartoul

Labels
P: Low T: Beginner T: Misc T: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Stream() API and refactor/fix bugs in buffer.go m3db/m3
3 participants
@prateek @robskillington @richardartoul