Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing coverage reporting #4313

Open
kentzeng12 opened this issue Nov 8, 2024 · 1 comment · Fixed by #4314
Open

Fix failing coverage reporting #4313

kentzeng12 opened this issue Nov 8, 2024 · 1 comment · Fixed by #4314
Assignees

Comments

@kentzeng12
Copy link
Collaborator

Our pipeline tests are running really slowly on buildkite, example: https://buildkite.com/uberopensource/m3-monorepo-ci-uber-oss/builds/679.

This is due to coverage reporting being broken, which is causing the tests to sleep for 30 seconds repeatedly.

Coverage reporting is happening in the makefile in these lines:

This is the script that is doing the coverage reporting: https://github.com/m3db/ci-scripts/blob/53a70df5b14add46dbcbcbc28d91dbf6fd7cd683/codecov.sh

The temporary fix right now is to pause coverage reporting, so that our pipeline tests run faster whenever someone is trying to create a PR. We are using SKIP_CODECOV env variable to pause coverage reporting.

@kentzeng12
Copy link
Collaborator Author

We only paused coverage reporting. Haven't addressed root cause.

@kentzeng12 kentzeng12 reopened this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant