Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we pass args to cordova run/build commands? #20

Closed
eladcandroid opened this issue Oct 9, 2018 · 5 comments
Closed

Can we pass args to cordova run/build commands? #20

eladcandroid opened this issue Oct 9, 2018 · 5 comments

Comments

@eladcandroid
Copy link

We need to pass a buildFlag argument according to this Cordova ios issue: apache/cordova-ios#407

@m0dch3n
Copy link
Owner

m0dch3n commented Oct 9, 2018

Hmmm, I'm asking myself how the command api should look like, because currently the args are passed to the vue cli service...

@m0dch3n
Copy link
Owner

m0dch3n commented Oct 9, 2018

I mean these arguments:

https://github.com/vuejs/vue-cli/blob/7c91a187e46d7bb9a9b83bcdf97631794ac36b10/packages/%40vue/cli-service/lib/commands/serve.js#L18

Should we drop support for them and pass all the arguments to cordova?

@m0dch3n
Copy link
Owner

m0dch3n commented Oct 9, 2018

In the issue they are also talking about a build.json, maybe this is a temporary solution, until they release their new major ios version...

@eladcandroid
Copy link
Author

You right. It works great with this build.json file in src-cordova dir:

{
  "ios": {
    "debug": {
      "buildFlag": ["-UseModernBuildSystem=0"]
    }
  }
}

Should we wait for a solution or to add this file to the generator to solve the issue?

@m0dch3n
Copy link
Owner

m0dch3n commented Oct 10, 2018

I prefer if the vue plugin doesn't handle all the special cordova stuff... In fact, the problem is, that, in the long term, you can't come arround to know how cordova works, how you add plugins, configure your config.xml etc...

Nevertheless, having the possibility of having args is maybe a good idea, however as mentioned, how would you distinct between args passed to vue serve/build and cordova run/build ?

After thinking about this, maybe we can add some sort of -interactive flag to vue, which then prompts the user to add args, before executing cordova run/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants