Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce jest matchers #97

Merged
merged 9 commits into from
Jun 13, 2022

Conversation

jurijzahn8019
Copy link
Contributor

Adds jest matchers intended to simplify usage of expects

Matchers will be only added if expect.extend function is present.

Fixes #96

@jurijzahn8019
Copy link
Contributor Author

Hello @m-radzikowski,

this is just a ping 😄

Copy link
Owner

@m-radzikowski m-radzikowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution! Please see my comments on the code.

@jurijzahn8019
Copy link
Contributor Author

Hi @m-radzikowski, i have made requested chenges :)

Copy link
Owner

@m-radzikowski m-radzikowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Please see the build fail on types check.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@c66e050). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main       #97   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         7           
  Lines           ?       165           
  Branches        ?        22           
========================================
  Hits            ?       165           
  Misses          ?         0           
  Partials        ?         0           
Impacted Files Coverage Δ
src/awsClientStub.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/jestMatchers.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66e050...7f3fb04. Read the comment docs.

@m-radzikowski m-radzikowski merged commit b5f2c10 into m-radzikowski:main Jun 13, 2022
@jurijzahn8019 jurijzahn8019 deleted the feat/jest-matchers branch June 13, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest matchers for the library
3 participants