fix!: recreate mock on reset() #76
Merged
+83
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents mock behaviors breaking subsequent behaviors between the reset() calls due to Sinon.JS bug #1572.
The resetBehavior() method, calling Sinon.JS stub.resetBehavior(), cannot be relied upon because of Sinon.JS bug #1572.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #67 turned out to be a consequence of a well-known Sinon.JS bug sinonjs/sinon#1572
The Sinon bug consequences are limited since we always use
sinon.matchexpressions, but in some scenarios, thereset()could not clean the stub properly and have the behavior leak between the tests. To solve this, now the Sinon stub is recreated on callingreset().Because of the Sinon.JS bug, the
resetBehavior()method, calling Sinon.JSstub.resetBehavior(), cannot be relied upon and is removed, since there is no easy fix for it.Fixes #67