fix!: Correct expect.assertions() count on CommandWith commands #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobbin
changed the title
lobbin
changed the title
lobbin
force-pushed
the
expect-assertions-count-fix
branch
from
7969163 to
a35e22a
Compare
1 task
m-radzikowski
approved these changes
Mar 17, 2024
m-radzikowski
changed the title
|
Released in v4.0.0. I've bumped the major version not to break any existing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When using assertion count with any of the CommandWith commands, they differ in count due to the matcher is using except within the matcher.
Fix:
The fix consists on using equals() from the matcher context instead of using a second expect.