-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bikeshed: conventions for CDC primitives #97
Comments
Sounds ok. |
I like this, but find some of the results inconsistent (c84cd8d):
Inconsistent use of suffix vs prefix is something I would trip over when typing too fast. |
I think |
Since nMigen uses I've adjusted Feedback? @sbourdeauducq @Wren6991 |
One reason I've hesitated to merge #40 so far is that I think the oMigen conventions for CDC primitives are a bit annoying. I think a better situation than the current one would be:
domain
,idomain
,rdomain
, etc, which only allow a single letter for domain designation, usedomain
,i_domain
,r_domain
,pll_domain
, etc.DomainRenamer
right after creation should allow changing the domain names through arguments. Notably this would includeAsyncFIFO
, which is probably responsible for most uses ofDomainRenamer
, but all other CDC primitives as well. Non-CDC modules may or may not allow that depending on intended use.Thoughts? @sbourdeauducq @jordens @Wren6991
The text was updated successfully, but these errors were encountered: