Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add required files to MANIFEST.in #930

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: add required files to MANIFEST.in #930

merged 1 commit into from
Dec 17, 2024

Conversation

frostming
Copy link
Contributor

No description provided.

@Barabazs
Copy link
Collaborator

Please add an explanation for why this is needed.

@Barabazs Barabazs added the question Further information is requested label Dec 16, 2024
@frostming
Copy link
Contributor Author

frostming commented Dec 17, 2024 •
edited
Loading

To fix the sdist built from the source, it is missing requirements.txt to build successfully

To reproduce, install build first: https://pypi.org/p/build , then run:

python -m build

You will notice a failure when building the wheel because by default build builds wheel from the result sdist.

@Barabazs Barabazs changed the title Update MANIFEST.in to include necessary files fix: add required files to MANIFEST.in Dec 17, 2024
@Barabazs Barabazs merged commit 3027cc3 into m-bain:main Dec 17, 2024
@Barabazs
Copy link
Collaborator

Thank you for clarifying and the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barabazs Barabazs Barabazs approved these changes

Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frostming @Barabazs