Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Reset: Is it possible to disable returning 404 when user is not found? #987

Closed
misham opened this issue Oct 20, 2017 · 4 comments
Closed

Comments

@misham
Copy link

misham commented Oct 20, 2017

I'm trying not having to re-implement the entire controller functionality and just want to change the behavior a bit.

I don't care if the user is found or not, the response should always be 200.

Is the only solution to just re-implement POST create for the passwords controller?

Thank you

@MaicolBen
Copy link
Collaborator

Seems that 404 is the only way to reach render_create_error, so maybe you want to override it. In the future, we'll refactor the controller.

@misham
Copy link
Author

misham commented Oct 21, 2017

I'd be interested in submitting a PR around this. Would it be sufficient to pass another variable to skip the 404 error? E.g. POST {pasword: 'somepass', ..., skip_404: true}

That feels a bit hacky, but not sure what would make more sense here? Maybe a global config that can be set in the initializer?

@MaicolBen
Copy link
Collaborator

MaicolBen commented Oct 21, 2017

Using params for that is ugly, and we can't make global configs for everything, I made a PR where you can override render_not_found_error in the passwords controller

@misham
Copy link
Author

misham commented Oct 21, 2017

That's great! Do you know when the next release will land?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants