Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to prevent persisting the same token to user table when in batch mode? #934

Closed
tmfrnz opened this issue Jul 30, 2017 · 1 comment

Comments

@tmfrnz
Copy link

tmfrnz commented Jul 30, 2017

Following-up on #922

When in batch mode, it appears that tokens are written to user table in database for every request, even when the tokens only changes for the first request.

These unnecessary operations can lead to poor performance, especially when combined with model versioning (eg using paper_trail).

Our test (paper_trail enabled) with 100 requests, resulted in a total processing time of 25s with change_headers_on_each_request enabled and only 6s with change_headers_on_each_request disabled.

@lynndylanhurley
Copy link
Owner

Just commented on #922. Let's continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants