Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render_create_error not called when no json is provided #929

Closed
mithom opened this issue Jul 23, 2017 · 4 comments
Closed

render_create_error not called when no json is provided #929

mithom opened this issue Jul 23, 2017 · 4 comments

Comments

@mithom
Copy link

mithom commented Jul 23, 2017

when sending an empty POST request, there does not seem to be a function to override the returned error.
The function render_create_error is not called and render_create_error_bad_credentials is never called as far as I can detect. Is there a way to solve the first part of this problem (the not being able to customize the render)?

@zachfeldman
Copy link
Contributor

@mithom have you tried just overriding the entire action on the controller action in question?

@mithom
Copy link
Author

mithom commented Oct 8, 2017

I think i did this to solve the problem (will have to check to be sure), but the fact you cannot customize this error seems a big shortcoming/bug to me, as it is nowhere documented that the missing of post data excludes the render_create_error method.

@zachfeldman
Copy link
Contributor

@mithom sure, if you have time we'd enjoy a pull request to fix this, possibly an addition to the README or a code fix.

@mithom
Copy link
Author

mithom commented Aug 24, 2019

I am not working on this project anymore and likely will not have time or think about checking the codebase again. So this can be closed as it is 2y oldwithout action

@mithom mithom closed this as completed Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants