Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reset password if registered by omniauth #77

Closed
smarquez1 opened this issue Nov 26, 2014 · 5 comments
Closed

Cannot reset password if registered by omniauth #77

smarquez1 opened this issue Nov 26, 2014 · 5 comments

Comments

@smarquez1
Copy link

After I register a new user using Omniauth, if I'm logged out and try to reset my password I cannot do it.
I think the problem resides in the passwords controller L30.

Of course, the user still can log in using the same omniauth account so this might not be considered a bug.

@smarquez1 smarquez1 changed the title Cannot reset password if regisered by omniauth Cannot reset password if registered by omniauth Nov 26, 2014
@nicolas-besnard
Copy link
Contributor

I think this is a normal behavior. You can't change your password because you don't define it when you register. And it's not the purpose of omniauth login :)

@lynndylanhurley
Copy link
Owner

@smarquez1 - that is the expected behavior. The idea is that OmniAuth users are using OAuth providers to verify their identity, so the password system is redundant.

@smarquez1
Copy link
Author

Cool, thanks for the clarification

@smarquez1
Copy link
Author

Sorry to revive this issue, but should shouldn't we return a message like:
"This account does not require a password. Sign in using your Linkedin account instead" in https://github.com/lynndylanhurley/devise_token_auth/blob/master/app/controllers/devise_token_auth/passwords_controller.rb#L59 ?

@nicolas-besnard
Copy link
Contributor

Your users shouldn't be able to use this controller if they are logged-in via Omniauth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants