-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor error in README with regard to usage alongside Devise #745
Comments
I was just about to post about this. It seems the instructions imply you should set that value to true, but the example code has that line commented out. I was confused as well. |
Also, when I follow the instructions, I get a conflicting routes error:
Here are my routes:
|
I don't know if this really solves the issue, but to avoid having duplicate route names, I was able to solve it by configuring my routes.rb like this:
This way you get "new_user_devise_session" for devise, and "new_user_session" for devise_token_auth |
Replace |
@KjellMorgenstern @gbrl |
So, to clarify, the config file SHOULD or SHOULD NOT be changed to:
|
@lynndylanhurley this seems like a fairly simple one to close if we have your blessing for the above fix to the README? I can update it if so. |
Hi,
I noticed the README gives the following snippet of code (https://github.com/lynndylanhurley/devise_token_auth#configinitializersdevise_token_authrb):
This does not make sense to me. Shouldn't this be:
If this is a really a mistake I'll create a pull request but I'm not sure at this point yet.
The text was updated successfully, but these errors were encountered: