Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Error Message on 5.0 #698

Closed
juddey opened this issue Aug 14, 2016 · 1 comment
Closed

Deprecation Error Message on 5.0 #698

juddey opened this issue Aug 14, 2016 · 1 comment

Comments

@juddey
Copy link
Contributor

juddey commented Aug 14, 2016

Just ran a migration using the generated template and got this deprecation notice:

DEPRECATION WARNING: Directly inheriting from ActiveRecord::Migration is deprecated. Please specify the Rails release the migration was written for:

class DeviseTokenAuthCreateUsers < ActiveRecord::Migration[4.2] (called from <main> at bin/rake:4)

Let me know if you want a PR to fix and I'll cook something up.
@lynndylanhurley
Copy link
Owner

Let me know if you want a PR to fix and I'll cook something up.

Yes please 👍

juddey added a commit to juddey/devise_token_auth that referenced this issue Aug 14, 2016
@juddey
Fix for issue lynndylanhurley#698
e9385d4 
Update migration template to include version of Rails
to silence a deprecation warning.
@juddey juddey mentioned this issue Aug 14, 2016
Merged
@juddey juddey closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lynndylanhurley @juddey