Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude devise validatable module? #613

Closed
salmanasiddiqui opened this issue Apr 17, 2016 · 1 comment
Closed

exclude devise validatable module? #613

salmanasiddiqui opened this issue Apr 17, 2016 · 1 comment

Comments

@salmanasiddiqui
Copy link
Contributor

Devise token auth overrides email_required? and email_changed? methods just to disable devise validations. Overriding email_required? seems ok as its a method defined by devise so people can expect devise token auth to override it. But overriding email_changed? is not the cleanest way to disable validations. I wanted to use it in condition for callbacks but ended up using email_change after coming to know that email_changed? is overridden by devise token auth

As devise suggests itself, that if there is a need to modify devise validations, then its better to just implement your own validators and exclude validatable module.

@zachfeldman
Copy link
Contributor

Closed in favor of #662 (just to consolidate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants