-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot add more parameters at sign_up #22
Comments
Good catch. This gem should leverage devise's existing strong parameter system (it doesn't right now). For now you can try overriding this method. I'll set this up ASAP. |
You should now be able to whitelist additional params using the existing devise conventions. For example, if you want to allow users to specify their class ApplicationController < ActionController::Base
include DeviseTokenAuth::Concerns::SetUserByToken
before_action :configure_permitted_parameters, if: :devise_controller?
respond_to :json
protected
def configure_permitted_parameters
devise_parameter_sanitizer.for(:sign_up) << :zodiac_sign
end
end Please check out devise_token_auth version |
Awesome! it works great, but somehow the 'auth:email-confirmation-success' is broken again, could you verify? |
I'll take a look ASAP. |
@smarquez1 - I just tested this with the version of your app that I cloned a few days ago. I updated the devise_token_auth gem to version Also, this update didn't touch anything related to client-side events. I haven't pulled your latest code, but something else on the front-end must be causing the issue. |
Thanks so much @lynndylanhurley it works now (I'm on beta3 btw). |
No problem! Thanks for pointing this out. |
The devise way to add extra user parameters is not working right now, at least not on sign_up.
https://github.com/plataformatec/devise#strong-parameters
The text was updated successfully, but these errors were encountered: