Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing user credential in confirmation redirect url querystring #1292

Closed
CDimonaco opened this issue May 21, 2019 · 1 comment
Closed

Missing user credential in confirmation redirect url querystring #1292

CDimonaco opened this issue May 21, 2019 · 1 comment

Comments

@CDimonaco
Copy link

After upgrading from devise_token_auth -> 1.0.0 to devise_token_auth: -> 1.1.0', when a user sign up and receive the confirmation email, the backend will redirect to the confirmation redirect url, without client, access-token, token-type and the other related user authentication stuff as query string params.

With the version '1.1.0', the only querystring params passed to the redirect confirmation url is the account_confirmation_success set to true.

Is an intended behavior? I can't found anything really useful on the docs or changelog.

Thanks in advance.
Version: 1.1.0

  • Ruby: 2.6.1
  • Gems: ActiveRecord
  • Custom Overrides: none
  • Custom Frontend: none
@MaicolBen
Copy link
Collaborator

That's expected from that version, we don't sign in anymore as we don't want to depend in the trackable module (awful design and a majority of people isn't using it), also it's kind of insecure logging there. If you are already logged in, we send you the credentials.

Check #1075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants