-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No create in confirmations controller? #1093
Comments
Hey @davidwparker , can you be more specific? My understanding is that a confirmation just sends a token back to the server, we confirm the user, then send back an auth token for you to user for to keep them logged in after that. The I suppose it might be nice to integrate this directly into the lib as a controller action though! Feel free to write a PR. |
@zachfeldman - when the user hits the application from the email, it will never hit the I decided to just manually override this controller. It may be nice to add as you say, but I don't think it's that important and it's pretty easy to override. Thanks! |
Ok! |
I noticed in the confirmations controller that there is no create action.
I'm using rails-api, and the plan is to have a 100% React frontend. As Rails won't be handling any views, I don't expect devise_token_auth to handle confirmations w/a handler, but instead I would handle it via React.
Is the best way to handle this to override the default confirmations controller? Or is there a plan to make a create action so the gem can handle it?
Thanks!
The text was updated successfully, but these errors were encountered: