-
-
Notifications
You must be signed in to change notification settings - Fork 66
collating test_result bundles in Xcode 11 crashes #145
Comments
This works fine for Xcode 10? |
Yes it does. Also, take a look at this as well. |
@jineshqa do you have a theory that they are somehow related? This issue that you created seems to indicate that there is a problem collating test result bundles. The issue that you reference fastlane/fastlane#15138 indicates that there is a crash after uploading to testflight. |
I saw that you commented in the issue. According to the stack trace of the crash, these are not related issues. |
As this fails in both Xcode 10 and Xcode 11, this is probably not related to the versions. I haven't changed anything in the collation of test result bundles of v3.8.4 vs. v.3.8.x. You must have something in your project that is catching an edge case that I have not encountered before. I need either the test result bundles to see why the collation fails, or a sample project that you can submit freely that exhibits the problem. 🙏 |
Hey Lyndsey, This does not fail on xcode 10. Thanks, |
Okay. Can you provide the test result bundles? |
Oh, and another question, if you remove the request to create test_result bundles, does it still crash? |
I am not sure I can try. |
Also, will get you sample project. |
This is didn't help. |
Sample project is located here Test output is attached. |
@lyndsey-ferguson is above info good enough. |
@jineshqa yes, I was able to fix the crash. I have a PR open. Can you modify your Pluginfile:
If there are still problems, please let me know and attach the console output as a text file to this issue (makes it easier for me to review). If it works, please let me know. |
However, I do not believe that collation now works. The test summaries no longer exist and the tests failures and passes are no longer listed. |
It looks like there is a new format: |
Ok, this looks like a lot of work. |
I'm going to change this issue to a Feature Request to support Xcode 11 format. |
Actually, I can issue a fix for now until test_result bundles can be collated with the new format. |
@jineshqa try running the branch I suggested above with multi_scan. It will use version 2 of the test result bundle path |
This should have everything you need. |
Please try again. Delete your Gemfile.lock file, make sure that you have modified your Pluginfile:
If there are still problems, please let me know and attach the complete console output as a text file to this issue (makes it easier for me to review). If it works, please let me know. |
Is the |
Does that |
Enable_testability is on and xctest file does exist. However I get this message at the beginning of the run. Do you think this has anything to do with missing tests? |
Any idea what would cause this?
|
Not offhand. It is stating that the |
With regards to this:
This is just stating that the run cannot use the You could try adding another breakpoint once you get |
I tried to run tests with xcodebuild and it ran just fine. So I'm not sure what is causing this. Command line tools are solid. |
@lyndsey-ferguson I feel terrible for wasting your time. I think you should just go ahead and merge this PR. Someone already confirmed that it is working for them. |
Ok...I have to clean it up a bit, I'll do that and you'll see it merged soon. |
Fixed in v3.8.7 |
@lyndsey-ferguson didn't want to spam by creating a new issue but I am seeing this after upgrading to latest version of the plugin. Kindly let me know if I should create a new issue or it is just me. |
Ug. |
I don't have time to test, but it looks like it is using the new apis. Sorry for this. |
Please do not apologize...you are doing awesome work for the community. |
This is not professional to drop a broken gem out there. |
Well, @szymon-kazmierczak tested and it was working for him. It could be just me. |
No, I refactored the code and didn't adequately test it. |
@jineshqa, can you modify your Pluginfile:
If there are still problems, please let me know and attach the console output as a text file to this issue (makes it easier for me to review). If it works, please let me know. |
@jineshqa are you doing it now? Have you tested it yet? Just kidding 😄. Let me know when you've had a chance to look at it. |
Hi @lyndsey-ferguson, it is working fine now. That was a nice quick turn around. |
truly fixed in v3.8.8 |
Fix verified on |
New Issue Checklist
fastlane-plugin-test_center
to the latest versionIssue Description
I am trying to run tests using multi_scan, at the end of parallel test run collate actions fail. Please see the output for more details.
Complete output when running fastlane, including the stack trace and command used
Environment
The text was updated successfully, but these errors were encountered: