Prevent deleting databases that have attached tables (apache#5749)

* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments
lyft · Aug 28, 2018 · 6cc52c6 · 6cc52c6
1 parent bd1f36d
commit 6cc52c6
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/superset/views/core.py b/superset/views/core.py
@@ -256,6 +256,13 @@ def pre_add(self, db):
     def pre_update(self, db):
         self.pre_add(db)
 
+    def pre_delete(self, obj):
+        if obj.tables:
+            raise SupersetException(Markup(
+                'Cannot delete a database that has tables attached. '
+                "Here's the list of associated tables: " +
+                ', '.join('{}'.format(o) for o in obj.tables)))
+
     def _delete(self, pk):
         DeleteMixin._delete(self, pk)