Specifying lycheeVersion as "nightly" broken

[osslate]

As the GitHub Action prepends "v" to the lycheeVersion (so it becomes vnightly instead of nightly) when grabbing the binary from GitHub, trying to use the nightly version with this GitHub Action is broken.

[mre]

Oh well.

Wonder how we can fix it.

[osslate]

To avoid breaking compatibility with people already using the Action, a solution might be introducing a useNightly option that overrides lycheeVersion.

[mre]

We could introduce a breaking change with a new version but yeah, it's not ideal. Alternatively, we could check if version is nightly and avoid prepending the v.

[dscho]

Seems that this is broken even on master now, because the nightly artifact changed name from lychee-nightly-x86_64-unknown-linux-gnu.tar.gz to lychee-x86_64-unknown-linux-gnu.tar.gz (note the removed infix nightly-).

[dscho]

Seems that this is broken even on master now

The reason seems to be lycheeverse/lychee#1464, which renamed the release assets. Note: This will be a major problem once the next lychee version is released, because then not only the nightly version will be broken.

I opened #234 to fix that.

[mre]

@dscho fixed it. @osslate, please try again. 😊
If it doesn't work as expected, please reopen.