Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Wrapper for Node views #1

Open
mirus-ua opened this issue Apr 19, 2022 · 12 comments
Open

[Feature request] Wrapper for Node views #1

mirus-ua opened this issue Apr 19, 2022 · 12 comments

Comments

@mirus-ua
Copy link

Hi.
I'm playing around with solidjs and trying to figure out which editor should I use for a project. Tiptap looks great and solid-tiptap also is handy, but I found that the library doesn't have any wrapper for solid components. The simplest example of why this is important is the possibility to use components libraries such as hope-ui.

I could even help if you'll give me a direction because I'm new in solid and tiptap ecosystem

@lxsmnsyc
Copy link
Owner

Thanks for showing interest. I'm not sure what it means to have a wrapper for Solid Components (or rather Node View, not sure how related they are to one another) and perhaps you can give me an example on how would it work?

@mirus-ua
Copy link
Author

I'm saying about a possibility like react https://tiptap.dev/guide/node-views/react
Rendering solid components inside the text editor will increase the flexibility of the library

@lxsmnsyc
Copy link
Owner

lxsmnsyc commented Apr 20, 2022

I'm saying about a possibility like react https://tiptap.dev/guide/node-views/react

Rendering solid components inside the text editor will increase the flexibility of the library

I might have missed this before, thanks! I'll take a look at this

@amirhhashemi
Copy link
Contributor

Hi @lxsmnsyc. Any progress? I need this in my project and I'm trying to implement it. Just wanted to make sure we don't work on the same thing simultaneously.

@lxsmnsyc
Copy link
Owner

lxsmnsyc commented Apr 6, 2023

I haven't really explored Tiptap again since last year. I'm open for PRs though

@eugenejeonme
Copy link

I needed it too, so I wrote some code.
(*Written by forking this repository)

If you need to, you can create a PR.

Repository URL : https://github.com/EugeneJeonME/solid-tiptap/tree/SolidNodeViewRenderer

image

image

@liuyike98
Copy link

@eugenejeonme i'm also doing work for this, glad to see that you have finish this! save me a lot of time, i will try it soon :)

@shiro
Copy link

shiro commented May 30, 2023

I've tested the code and didn't find any bugs so far, it works perfectly and allows rendering solid components in the editor!

Any plans to merge that back into this repository?

@eugenejeonme
Copy link

@mirus-ua @amirhhashemi @liuyike98 @shiro
You have created a PR. #9
This should work fine, right?

@Ladvace
Copy link

Ladvace commented Sep 5, 2023

Any update?

@camplowell
Copy link

@lxsmnsyc Any updates on this?
I understand if this project is on the back burner, but last I saw the PR just kind of disappeared because Eugene deleted his fork - your last comment on the PR seemed positive, but nothing seems to have happened since.

@eugenejeonme
Copy link

@lxsmnsyc Any updates on this? I understand if this project is on the back burner, but last I saw the PR just kind of disappeared because Eugene deleted his fork - your last comment on the PR seemed positive, but nothing seems to have happened since.

Archived and deleted the #9's REPO because I felt like PR and ISSUE management wasn't working well.
I didn't know if anyone still needed it.
Sorry. Do you need any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants