From 4f158c2ce55c9c0883392b64ebc028be23c6d849 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20Pereira?= Date: Wed, 25 Oct 2023 12:49:09 +0100 Subject: [PATCH] Assign bulkTimers a parent The parent/child relationship is not used to manage memory. It's only used to keep the objects together when moving them between threads (so that the entire subtree is moved by moveToThread). That's not the case here, but it's good practice. Reference: https://www.kdab.com/qobject_ownership_propagate_const/ --- lib/Emulation.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Emulation.h b/lib/Emulation.h index 7d2263b5..1217386e 100644 --- a/lib/Emulation.h +++ b/lib/Emulation.h @@ -510,8 +510,8 @@ private slots: private: bool _usesMouse; bool _bracketedPasteMode; - QTimer _bulkTimer1; - QTimer _bulkTimer2; + QTimer _bulkTimer1{this}; + QTimer _bulkTimer2{this}; };