Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Fonts settings to LXQt config #1023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sledgehammer999
Copy link

Partially implements #1022

With this, functionality is not lost or changed.
The fontsconfig is still written, however all related values are now saved/loaded to lxqt.conf first.

There's one caveat because I don't your policy on this. If this gets merged as-is the user's old settings will be lost. The user will need to customize them again.
Do you want a migration code that will load the customized settings into the lxqt.conf from fonts.conf if they are missing? It will makes things much more complicated though...

If this gets approve the future PRs will be in these stages:

  • stage 2: Write the Fonts settings into the appropriate values of xsettings/gsettings/settings.ini
  • stage 3: Yank out the code for xsettings and migrate it to lxqt-session. Make the xsettings deamon start at session start and continue running for the whole session. Reload it when changes are done to the settings.
  • stage 4: Investigate what needs to be done on the lxqt-qtplugin side.

@sledgehammer999
Copy link
Author

Don't get confused by the diff. The actual changes are minimal. I moved code around and that resulted in a big diff.

@stefonarch stefonarch requested a review from palinek August 19, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant