Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ilya fedin fix static build #215

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

luis-pereira
Copy link
Member

Fixes #208.
@Ilya87 Can't write to #212. So I created this PR with your commits and mine on top.
Tested with shared and static builds.

ilya-fedin and others added 3 commits July 1, 2020 16:49
To avoid symbol conflict with Qt
Build type configured by the CMake BUILD_SHARED_LIBS option. The default is
shared.
Static build requires a Qt static build. It will fail otherwise.
@ilya-fedin
Copy link

Thanks! Looks valid 🤔

@luis-pereira
Copy link
Member Author

@ilya-fedin Did you put this to the test ?

@ilya-fedin
Copy link

Did you put this to the test ?

I tested with tdesktop's cmake rules a long time ago, but testing with lxqt-qtplugin's cmake rules wouldn't be an easy task with tdesktop 😥

@luis-pereira
Copy link
Member Author

I tested with tdesktop's cmake rules a long time ago, but testing with lxqt-qtplugin's cmake rules wouldn't be an easy task with tdesktop disappointed_relieved

I'm confused. So what's the purpose ?

@ilya-fedin
Copy link

ilya-fedin commented Jul 29, 2020

I'm confused. So what's the purpose ?

To get lxqt's icon theme & other appearance settings even on static binary

@luis-pereira
Copy link
Member Author

To get lxqt's icon theme & other appearance settings even on static binary

Of course. I meant a PR that can't be tested.

@ilya-fedin
Copy link

ilya-fedin commented Jul 31, 2020

I meant a PR that can't be tested.

I don't know. I tried to build libqtxdg with upstream cmake rules, but encountered into Requested 'glib-2.0 >= 2.50' but version of GLib is 2.40.2 when building lxqt-build-tools, static build of tdesktop works only on Ubuntu 14.04 due to hardcoded paths and hacks like glibc wraps 🙈

@luis-pereira
Copy link
Member Author

libqtxdg requires 2.41.
Version 2.50 is a libfm-qt requirement.

I wasn't aware that lxqt-build-tools had Qt5 and GLIB requirements. I was actually asked for a review, but never did, some real life issues got in the way.

The purpose of such requirements are probably to fail as soon as possible. I don't agree with version check at lxqt-build-tools. The packages needed to build LXQt are much more than those two.

@ilya-fedin
Copy link

libqtxdg requires 2.41.

It is still greater than 2.40 (even though I need only xdgiconloader for lxqt-qtplugin) :(

CMake Error at /opt/cmake/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
  Could NOT find GLIB: Found unsuitable version "2.40.2", but required is at
  least "2.41.0" (found
  /usr/include/glib-2.0;/usr/lib/x86_64-linux-gnu/glib-2.0/include)

@ilya-fedin
Copy link

I removed the check and confirm that this PR doesn't work with upstream cmake rules
28_LibQtXdg..txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicts with QtGui symbols on static link
2 participants