-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ilya fedin fix static build #215
base: master
Are you sure you want to change the base?
Conversation
To avoid symbol conflict with Qt
Build type configured by the CMake BUILD_SHARED_LIBS option. The default is shared. Static build requires a Qt static build. It will fail otherwise.
Thanks! Looks valid 🤔 |
@ilya-fedin Did you put this to the test ? |
I tested with tdesktop's cmake rules a long time ago, but testing with lxqt-qtplugin's cmake rules wouldn't be an easy task with tdesktop 😥 |
I'm confused. So what's the purpose ? |
To get lxqt's icon theme & other appearance settings even on static binary |
Of course. I meant a PR that can't be tested. |
I don't know. I tried to build libqtxdg with upstream cmake rules, but encountered into |
I wasn't aware that The purpose of such requirements are probably to fail as soon as possible. I don't agree with version check at |
It is still greater than 2.40 (even though I need only xdgiconloader for lxqt-qtplugin) :(
|
I removed the check and confirm that this PR doesn't work with upstream cmake rules |
Fixes #208.
@Ilya87 Can't write to #212. So I created this PR with your commits and mine on top.
Tested with shared and static builds.