Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preference: color of the background and selection background #440

Closed
alt-tab-macos-bot opened this issue Jul 19, 2020 · 2 comments
Closed
Labels
preference Introduction of a new preference

Comments

@alt-tab-macos-bot
Copy link

This issue was opened by a bot after a user submitted feedback through the in-app form.

Message:

背景色と選択タブの色を変更できるようにして欲しい。

Debug profile

  • App version: 4.5.0
  • App preferences:
    • NSWindow Frame com.sindresorhus.Preferences.FrameAutosaveName: 2093 475 331 267 1440 -71 1920 1057
    • SUHasLaunchedBefore: 1
    • SULastCheckTime: 2020-07-18 15:25:13 +0000
    • alignThumbnails: 0
    • fadeOutAnimation: false
    • hideSpaceNumberLabels: true
    • holdShortcut: ⌥
    • maxScreenUsage: 90
    • nextWindowShortcut: E
    • preferencesVersion: 4.5.0
    • previousWindowShortcut: Q
    • rowsCount: 3
    • showOnScreen: 1
    • showTabsAsWindows: false
    • theme: 0
    • titleTruncation: 0
    • windowDisplayDelay: 0
  • Applications: 67
  • Windows: 9
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, spaceId: 515, spaceIndex: 1}
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, spaceId: 515, spaceIndex: 3}
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, spaceId: 278, spaceIndex: 1}
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, spaceId: 278, spaceIndex: 1}
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, spaceId: 278, spaceIndex: 1}
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, spaceId: 7, spaceIndex: 2}
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, spaceId: 278, spaceIndex: 1}
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, spaceId: 278, spaceIndex: 1}
    • {isFullscreen: false, isMinimized: false, isHidden: false, isTabbed: true, isOnAllSpaces: false, spaceId: 278, spaceIndex: 1}
  • OS version: バージョン10.15.5(ビルド19F101)
  • OS architecture: x86_64
  • Locale: ja_JP (current)
  • Spaces: 4
  • Dark mode: Dark
  • "Displays have separate Spaces": checked
  • Hardware model: MacBookPro14,1
  • Screens: 2
    • {x: 0.0, y: 0.0, width: 1440.0, height: 900.0}
    • {x: 1440.0, y: -71.0, width: 1920.0, height: 1080.0}
  • CPU model: Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
  • Memory size: 17.18 GB
  • Active CPU count: 4
  • Current CPU frequency: 2.3 Ghz
  • Resource utilization:
    • CPU: 0.5%
    • Memory: 108M
    • Threads count: 12

@lwouis lwouis changed the title [In-app feedback] Add preference: color of the background and selection background Jul 19, 2020
@lwouis
Copy link
Owner

lwouis commented Jul 19, 2020

While I like the idea of users customizing colors to their own taste, this request sounds to me like someone wanting to customize the subtitles color in a video player app.

It is a feature that i can't imagine many people would use, and i also can't imagine how we could let users change colors without shooting themselves in the foot with readability problems. The current background is not a color by the way. It is a dynamic color system. We are using a standard material from macOS which blurs what's behind it. There is no API to tint it with an accent color, so that would mean making a custom implementation that simulates the native one. That sounds like a lot of trouble, albeit probably doable.

I would be open for a PR, but i don't think this feature is where i should be spending my time and energy currently to be honest

@lwouis lwouis added the preference Introduction of a new preference label Jul 19, 2020
@lwouis
Copy link
Owner

lwouis commented Aug 6, 2020

Closing this ticket until someone provides a detailed plan of how that feature would work out. See the discussion in this other thread for example of the depths involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preference Introduction of a new preference
Projects
None yet
Development

No branches or pull requests

2 participants