Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new theme/layout which mimics the built-in app switcher #1148

Closed
kodmanyagha opened this issue Sep 21, 2021 · 6 comments
Closed

Add new theme/layout which mimics the built-in app switcher #1148

kodmanyagha opened this issue Sep 21, 2021 · 6 comments
Labels
enhancement New feature or request support/question The author was looking for help, or didn't understand something and though it was a bug unclear Need help from the author to provide more information to flesh out the issue

Comments

@kodmanyagha
Copy link

There are "macOS" and "Windows 10" style window lists. Is it possible that you add "Mac Style" window list?

Thanks...

@kodmanyagha kodmanyagha added the enhancement New feature or request label Sep 21, 2021
@lwouis
Copy link
Owner

lwouis commented Sep 21, 2021

Hi,

I'm confused by your distinction between macOS and Mac Style. macOS is the name of the mac operating system. This is the default theme. It aims to blend with the all the other apps and the operating system, on a mac.

Could you please go into more details as to what this new theme would change? You can see here the colors, border values, etc, related to themes:

MacroPreference(" macOS", (0, 5, 20, .clear, NSColor(red: 0, green: 0, blue: 0, alpha: 0.3))),
.

Thank you

@lwouis lwouis added support/question The author was looking for help, or didn't understand something and though it was a bug unclear Need help from the author to provide more information to flesh out the issue labels Sep 21, 2021
@kodmanyagha
Copy link
Author

kodmanyagha commented Sep 22, 2021

Hi,

Let me tell you explain with screenshots.

Original Macos window list:
image

App window list:
image

If you can add this style then it will be awesome I think. Big icons, bottom labels..

@lwouis
Copy link
Owner

lwouis commented Sep 22, 2021

It would be complex to offer exactly this. You can get really close to it already today by increasing the app icon size in the preferences. The text is on the right side always though.

There are complex UX issues with the built-in app switcher design as well. Please read this: #82 (comment)

Offering alternate layouts like the one you suggest should be done properly. It shouldn't conflict with the existing appearance preferences. I'm not sure how we present that in the preferences.

@lwouis lwouis changed the title Mac Style Original Window List Add new theme/layout which mimics the built-in app switcher Sep 22, 2021
@gsemet
Copy link

gsemet commented Sep 28, 2021

Hi. Would I recommend to have a background selection a bit lighter, because it is hard to tell which icon is select on dark background. Windows 10 theme adds a contour, so it is more visible, but the macos theme is barely usable
Screenshot 2021-09-28 at 10 14 53

@lwouis
Copy link
Owner

lwouis commented Sep 28, 2021

Hi @gsemet, please read #82 (comment) for discussion around why it's hard to make a light background theme.

Of course, feel free to share a PR if you have an idea on how to execute it 👍

@lwouis
Copy link
Owner

lwouis commented Apr 29, 2022

Closing this as it's about someone submitting a new theme now, and there is nothing being discussed here anymore

@lwouis lwouis closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request support/question The author was looking for help, or didn't understand something and though it was a bug unclear Need help from the author to provide more information to flesh out the issue
Projects
None yet
Development

No branches or pull requests

3 participants