Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: added lv_zephyr url for creation of the zephyr based projects #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uLipe
Copy link

@uLipe uLipe commented Dec 9, 2024

Also added the Zephyr logo.

@uLipe uLipe changed the title manifests; added lv_zephyr url. manifests: added lv_zephyr url for creation of the zephyr based projects Dec 9, 2024
@uLipe uLipe force-pushed the feature/lv_zephyr branch from fba94eb to ca31dd7 Compare December 9, 2024 20:15
Copy link
Contributor

@liamHowatt liamHowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest_all_v1.1.0.json is not edited directly. A GitHub Action runs every 12 hours to update it automatically. https://github.com/lvgl/lvgl_project_creator/actions

@uLipe
Copy link
Author

uLipe commented Dec 10, 2024

@liamHowatt thanks for that, I was wondering if the manifests should be generated using the python script or if the actions would be responsible for that.

Now it is clear :)

Also added the Zephyr logo.

Signed-off-by: Felipe Neves <[email protected]>
@uLipe uLipe force-pushed the feature/lv_zephyr branch from ca31dd7 to b91299e Compare December 10, 2024 19:14
@uLipe uLipe requested a review from liamHowatt December 10, 2024 19:19
@uLipe
Copy link
Author

uLipe commented Dec 10, 2024

Removed the conflicts and added esp32 based board PTAL again

@kisvegabor
Copy link
Member

Looks good in general! I love the simplicity of the Zephyr project.

@richardgazdik please take a look at the logo.

Why do you call lv_timer_handler() here. If it's a workaround please add a comment.

Here it has full Markdown support, so you can use a link too. Now there is an issue with the links though: they open in the window of the project creator an not in a browser. @richardgazdik will fix it this week.

@uLipe
Copy link
Author

uLipe commented Dec 10, 2024

I think this extra call from the lv_timer_handler sounds like a leftover, since I grabbed the initial code from the modules/lvgl zephyr samples and simplified it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants