Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ES modules peer dependencies #27

Closed
luwes opened this issue Aug 3, 2019 · 1 comment
Closed

Fix ES modules peer dependencies #27

luwes opened this issue Aug 3, 2019 · 1 comment
Assignees
@luwes
Labels
bug Something isn't working

Comments

@luwes
Copy link
Owner

luwes commented Aug 3, 2019

Importing Sinuous with the new script module type doesn't work because the peer dependencies can't be resolved in the browser. e.g. sinuous/observable

<script type="module" src="https://unpkg.com/[email protected]/dist/sinuous.esm.js">
@luwes luwes added the bug Something isn't working label Aug 3, 2019
@luwes luwes self-assigned this Aug 3, 2019
@luwes luwes closed this as completed in 066b779 Aug 4, 2019
@luwes
Copy link
Owner Author

luwes commented Aug 4, 2019

Example https://codepen.io/luwes/pen/GVMeJR?editors=0011#0

@luwes luwes mentioned this issue Sep 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luwes luwes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luwes