Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Cygwin/MSYS #581

Merged
merged 2 commits into from
Feb 13, 2022
Merged

Fix build on Cygwin/MSYS #581

merged 2 commits into from
Feb 13, 2022

Conversation

DDoSolitary
Copy link
Contributor

  • Link Lua libraries on Cygwin as well. It runs on Windows, so doesn't support undefined symbols either.
  • Use OUTPUT_NAME instead of PREFIX to fix library names. Cygwin and MSYS use special prefixes for DLLs (cyg and msys-), so it doesn't work to simply remove the automatically added prefix.

@zhaozg zhaozg merged commit 9d602ab into luvit:master Feb 13, 2022
@DDoSolitary DDoSolitary deleted the patch-cygwin-build branch February 19, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants