Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid spec fixtures or expression can contains models other than Expressir::Model::Expressions::XXX? #233

Open
kwkwan opened this issue Feb 28, 2025 · 0 comments

Comments

@kwkwan
Copy link
Contributor

kwkwan commented Feb 28, 2025

Hi @ronaldtse, some spec fixtures seem invalid.

For example, in the yaml file https://raw.githubusercontent.com/lutaml/expressir/refs/heads/main/spec/syntax/mathematical_functions_schema.yaml (line 11457), the model Expressir::Model::Statements::Return contains expression with _class like Expressir::Model::Literals::Logical.

statements:
  - _class: Expressir::Model::Statements::Return
    expression:
      _class: Expressir::Model::Literals::Logical
      value: :FALSE

It seems that the values of expression are not correct. It is because expression should have _class like Expressir::Model::Expressions::XXX, but not Expressir::Model::Literals::Logical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant