Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse for Navbar #324

Closed
pdt590 opened this issue Oct 21, 2018 · 8 comments
Closed

Collapse for Navbar #324

pdt590 opened this issue Oct 21, 2018 · 8 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pdt590
Copy link

pdt590 commented Oct 21, 2018

Is your feature request related to a problem? Please describe.
Navbar cannot automatically collapse in mobile

Describe the solution you'd like

  • Navbar should change to Sidebar form when moving from desktop to mobile
  • Should support responsive/collapse mode for Navbar like bootstrap

Reference
https://bootstrap-vue.js.org/docs/components/navbar

@luisDanielRoviraContreras luisDanielRoviraContreras added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Oct 22, 2018
@jsinhSolanki
Copy link
Contributor

jsinhSolanki commented Dec 29, 2018

Maybe this can help to make PR.

https://codepen.io/joshmanders/pen/PQQBoR

there should be animation/transition in collapse

@CheyenneForbes
Copy link
Contributor

any update on this?

@luisDanielRoviraContreras
Copy link
Member

I'm going to get to work on this, I'll let you know when you're ready for it to be checked, thanks for the contribution

@luisDanielRoviraContreras
Copy link
Member

example-responsive

Ready, the functionality was added, I changed the structure a bit in the implementation with a new slot = "title"

Thank you very much for the contribution

@fergardi
Copy link
Contributor

What if I just want the sidebar component to be opened/closed, instead of the responsive mobile navbar functionality?

This behaviour should be optional.

@luisDanielRoviraContreras
Copy link
Member

@fergardi In the last version we added the new collapse property that generates the hidden menu, thank you very much

@fergardi
Copy link
Contributor

@luisDanielRoviraContreras how can I force the collapsible menu to close? If I click on a menu item and navigate to a new route, I want to close the menu automatically.

@piotrm73
Copy link

piotrm73 commented Nov 27, 2019

@luisDanielRoviraContreras how can I force the collapsible menu to close? If I click on a menu item and navigate to a new route, I want to close the menu automatically.

I did it like this:

watch: {
    $route() {
      const button = this.$refs.menuTop.$el.querySelector(
        ".vs-navbar--btn-responsive"
      );
      button.click();    
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants