Skip to content

Commit

Permalink
chore: Refactor dependencies in Cargo.toml to no longer fork pasta (#333
Browse files Browse the repository at this point in the history
)

* chore: Refactor dependencies in Cargo.toml to no longer fork pasta

- Updated dependencies in Cargo.toml by switching `pasta_curves` from a git repository to a specific version
- Amended `grumpkin-msm` dependency git repository link
- Removed the `[patch.crates-io]` section for `pasta_curves` due to the above changes.

* chore: point the grumpkin branch back to dev
  • Loading branch information
huitseeker authored Feb 20, 2024
1 parent 8d2bb89 commit 9cdccb3
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ rayon = "1.7"
rand_core = { version = "0.6", default-features = false }
rand_chacha = "0.3"
subtle = "2.5"
pasta_curves = { git = "https://github.com/lurk-lab/pasta_curves", branch="dev", features = ["repr-c", "serde"] }
pasta_curves = { version = "0.5.0", features = ["repr-c", "serde"] }
neptune = { git = "https://github.com/lurk-lab/neptune", branch="dev", default-features = false, features = ["abomonation"] }
generic-array = "1.0.0"
num-bigint = { version = "0.4", features = ["serde", "rand"] }
Expand Down Expand Up @@ -118,10 +118,6 @@ portable = ["grumpkin-msm/portable"]
cuda = ["grumpkin-msm/cuda"]
flamegraph = ["pprof/flamegraph", "pprof/criterion"]

# This is needed to ensure halo2curves, which imports pasta-curves, uses the *same* traits in bn256_grumpkin
[patch.crates-io]
pasta_curves = { git = "https://github.com/lurk-lab/pasta_curves", branch = "dev" }

[profile.dev-ci]
inherits = "dev"
# By compiling dependencies with optimizations, performing tests gets much faster.
Expand Down

1 comment on commit 9cdccb3

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Arecibo GPU benchmarks.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
32 vCPUs
125 GB RAM
Workflow run: https://github.com/lurk-lab/arecibo/actions/runs/7967272880

Benchmark Results

RecursiveSNARK-NIVC-2

ref=8d2bb89 ref=9cdccb3
Prove-NumCons-6540 44.35 ms (✅ 1.00x) 44.25 ms (✅ 1.00x faster)
Verify-NumCons-6540 34.17 ms (✅ 1.00x) 34.03 ms (✅ 1.00x faster)
Prove-NumCons-1028888 320.23 ms (✅ 1.00x) 335.10 ms (✅ 1.05x slower)
Verify-NumCons-1028888 251.41 ms (✅ 1.00x) 267.70 ms (✅ 1.06x slower)

CompressedSNARK-NIVC-Commitments-2

ref=8d2bb89 ref=9cdccb3
Prove-NumCons-6540 10.55 s (✅ 1.00x) 10.44 s (✅ 1.01x faster)
Verify-NumCons-6540 50.81 ms (✅ 1.00x) 51.01 ms (✅ 1.00x slower)
Prove-NumCons-1028888 52.01 s (✅ 1.00x) 51.54 s (✅ 1.01x faster)
Verify-NumCons-1028888 51.00 ms (✅ 1.00x) 51.01 ms (✅ 1.00x slower)

Made with criterion-table

Please sign in to comment.