Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native project compilation #433

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Fix native project compilation #433

merged 2 commits into from
Apr 2, 2023

Conversation

JeromeGalan
Copy link
Member

@JeromeGalan JeromeGalan commented Apr 1, 2023 •
edited
Loading

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@JeromeGalan JeromeGalan marked this pull request as ready for review April 1, 2023 21:34
@JeromeGalan JeromeGalan merged commit c726185 into main Apr 2, 2023
@nicolas-rabault nicolas-rabault deleted the rc_2.9.1 branch June 19, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-rabault nicolas-rabault Awaiting requested review from nicolas-rabault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JeromeGalan