Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reception header reading mistakes in case of buffer loop, fix #234 #426

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Fix reception header reading mistakes in case of buffer loop, fix #234 #426

merged 1 commit into from
Mar 28, 2023

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Feb 22, 2023 •
edited by JeromeGalan
Loading

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault self-assigned this Feb 22, 2023
@nicolas-rabault nicolas-rabault linked an issue Feb 22, 2023 that may be closed by this pull request
[BUG] messages not acked but still perfectly received #234
Closed
@nicolas-rabault nicolas-rabault added this to the 2.9.0 milestone Feb 22, 2023
@nicolas-rabault nicolas-rabault force-pushed the fix/reception_buffer_loop branch from dc6d413 to 4903b3d Compare February 22, 2023 17:24
@nicolas-rabault nicolas-rabault changed the base branch from main to rc_2.9.0 February 22, 2023 17:26
@JeromeGalan JeromeGalan force-pushed the fix/reception_buffer_loop branch from 4903b3d to d32fef7 Compare March 28, 2023 18:16
JeromeGalan
JeromeGalan approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a usefull fix. good job

@JeromeGalan JeromeGalan merged commit 4f70a66 into rc_2.9.0 Mar 28, 2023
@JeromeGalan JeromeGalan deleted the fix/reception_buffer_loop branch March 28, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeGalan JeromeGalan JeromeGalan approved these changes

@Salem-Tho Salem-Tho Awaiting requested review from Salem-Tho

Assignees

@nicolas-rabault nicolas-rabault

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

[BUG] messages not acked but still perfectly received
2 participants
@nicolas-rabault @JeromeGalan